[Yum-devel] [PATCH] yum-cron.sysvinit => yum-cron.service. BZ 893593

[James Antill]

On Mon, 2013-01-14 at 09:16 +0100, Zdenek Pavlas wrote:
> Based on the BZ patch, with some modifications:
> 
> - got rid of (now unused) yum-cron.sysvinit
> 
> - added BuildRequires: systemd-units, as recommended on
>   https://fedoraproject.org/wiki/PackagingDrafts:SystemdClarification#Packaging
> 
> - also updated yum-cron/Makefile

 ACK.

> RPMs have built fine in rawhide, but I'm not sure this patch is 100% correct,
> especially if hardcoding yum-cron.service path in Makefile is ok:
> 
> +install -D -m 644 yum-cron.service $(DESTDIR)/usr/lib/systemd/system/yum-cron.service
> 
> Is there a way to expand ${_unitdir} in Makefiles?

 You can do:

make DESTDIR=$RPM_BUILD_ROOT UNITDIR=%{_unitdir} install

...and have a default of:

UNITDIR=$(DESTDIR)/usr/lib/systemd/system

...in the Makefile somewhere.