[Yum-devel] [PATCH 5/5] remove the sequence check

Zdenek Pavlas zpavlas at redhat.com
Thu Feb 21 11:57:51 UTC 2013


The only case where this makes a difference is a broken old
package install.  Delta rebuild fails, and we retry downloading
a full rpm file instead.  Cost and probability of this is low.
OTOH, the check is quite slow, and avoiding it is a big win.
---
 yum/presto.py | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/yum/presto.py b/yum/presto.py
index b990c13..81e507f 100644
--- a/yum/presto.py
+++ b/yum/presto.py
@@ -89,12 +89,6 @@ class Presto:
                         old = el.get('oldepoch'), el.get('oldversion'), el.get('oldrelease')
                         if size >= best or old not in have:
                             continue
-                        # the old version is installed, seq check should never fail. kill this?
-                        seq = el.find('sequence').text
-                        if subprocess.call(['/usr/bin/applydeltarpm', '-C', '-s', seq]) != 0:
-                            self.verbose_logger.warn(_('Deltarpm sequence check failed for %s'), seq)
-                            continue
-
                         best = size
                         csum = el.find('checksum')
                         csum = csum.get('type'), csum.text
-- 
1.7.11.7



More information about the Yum-devel mailing list