[PATCH] Warn iff return_{groups, environments} returned an empty list. BZ 1043207

James Antill james at fedoraproject.org
Mon Dec 16 22:57:06 UTC 2013


On Mon, 2013-12-16 at 11:19 +0100, Zdenek Pavlas wrote:
> ---
>  yum/__init__.py | 27 +++++++++------------------
>  1 file changed, 9 insertions(+), 18 deletions(-)

 Let me start off by saying I detest for/else, why doesn't it work the
obvious way *sigh* :(.

 I think this is correct. I posted a bunch of patches mostly has the
same fix as this and some of the other issues with groups. In my version
of this bit I kept the try/except mainly to cut down on the whitespace
noise of the diffs. ... but also so it fails in a more obvious way if
things are triggering exceptions that shouldn't (I fixed at least one in
my group of patches :).
 Please review my patches, I put it into rawhide so adam can easily use
the result ... but I haven't pushed anything, yet. Might be worth
removing the try/excepts in another patch before it goes upstream too,
assuming we have more confidence then.



More information about the Yum-devel mailing list