[PATCH] Add a hint to the [y/d/N] prompt. BZ 980666

James Antill james at fedoraproject.org
Wed Aug 14 20:03:15 UTC 2013


On Wed, 2013-08-14 at 13:58 +0200, Zdenek Pavlas wrote:
> ---
>  cli.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/cli.py b/cli.py
> index 0eece17..3532761 100755
> --- a/cli.py
> +++ b/cli.py
> @@ -543,7 +543,7 @@ class YumBaseCli(yum.YumBase, output.YumOutput):
>              #  Note that we shouldn't just remove the 'd' option, or the options
>              # yum accepts will be different which is bad. So always accept it,
>              # but change the prompt.
> -            dl_only = extra={'downloadonly' :
> +            dl_only = {'downloadonly' :

 Can put this leftover in a separate commit and just push it :).

>                               (u'd', _('d'), _('download'),
>                                _('downloadonly'))}
>              if not stuff_to_download:
> @@ -551,7 +551,7 @@ class YumBaseCli(yum.YumBase, output.YumOutput):
>                  if ret == 'downloadonly':
>                      ret = None
>                  return ret
> -            return self.userconfirm(prompt=_('Is this ok [y/d/N]: '),
> +            return self.userconfirm(prompt=_('Is this ok (d to only download packages) [y/d/N]: '),
>                                      extra=dl_only)

 So I kind of understand the desire to give the user some more
indication of what 'd' is (although I think this might fix itself, as
people become aware of what d means) ... and 30 characters is almost
half the screen!
 Maybe do something like:

            msg = _('Is this ok [y/%sd%sownload/N]: ') %
                  (self.term.MODE['bold'], self.term.MODE['normal'])
            return self.userconfirm(prompt=msg, extra=dl_only)

...is enough ... esp. if we put something in the man page?



More information about the Yum-devel mailing list