[Yum-devel] [PATCH] Add option "curl_options". Helps BZ 849177
james at fedoraproject.org
Mon Apr 29 18:00:22 UTC 2013
On Mon, 2013-04-29 at 11:54 -0400, Zdenek Pavlas wrote:
> > NAK.
> > This is a really bad idea, as it basically means we have to continue to
> > use curl forever or break our configuration ... and any
> Yes, but I don't believe Yum/urlgrabber will use anything but curl
> in at least 5-10 years timeframe.
Yes, that's probably true. In fact we might stop using yum before we
ever think about changing the urlgrabber/curl layers. But I would have
happily said the same thing about urllib2 until just before urlgrabber
moved away from it.
> And we may document this option
> to be valid only for the curl backend.
There is only one backend, so any kind of documentation like this will
just confuse everyone. The only real implication would be "this works
right now, but don't expect it to continue to work" which is going to
annoy everyone who wants to use it, and will then annoy anyone who did
use it if we break it at some future point.
> > bad/incompatible/whatever changes curl makes to how it parses this
> > option can't be worked around by us (without doing way more work than
> > we'll want to).
> The pycurl API is/was pretty stable, IMO. And having a generic setopt()
> route from yum.conf to curl is a win, as it's much easier to just modify
> yum.conf than to patch and rebuild two packages (urlgrabber & yum).
Yes, but this is also the first option we've wanted/needed to add. And
it fixes a bug in ftp (which very few people have used for a long time)
for a bug that was low priority and one that has been closed WONTFIX
More information about the Yum-devel