[Yum-devel] [PATCH] Resurrect diskspacecheck=0 functionality
pmatilai at laiskiainen.org
Fri Apr 26 06:01:56 UTC 2013
On 04/26/2013 08:15 AM, Panu Matilainen wrote:
> On 04/25/2013 08:53 PM, James Antill wrote:
>> On Thu, 2013-04-25 at 19:32 +0300, Panu Matilainen wrote:
>>> On 04/25/2013 06:02 PM, James Antill wrote:
>>>> On Thu, 2013-04-25 at 09:09 +0300, Panu Matilainen wrote:
>>>>> Something in commit fc395ef14b135b3591488816ec902057fd8d03f4 makes
>>>>> diskspacecheck=0 not disable the disk space check at all. Moving
>>>>> the thing to initActionTs() where other similar initialization
>>>>> is done makes it work again. In addition, enable filtering of
>>>>> inode problems also to behave the same as rpm's --ignorespace.
>>>> Should change the documentation in yum.conf to explain that this
>>>> inodes too now. Apart from that ACK.
>>> Ok, I can add a blurb about that. Another alternative could be adding a
>>> separate option to skip inode check, at least the special case that
>>> "inspired" me to look at this would actually benefit from having them
>>> separated (weird filesystem which supposedly has no inode limit but
>>> apparently advertises this with 0 for total inodes...)
>> Yeh, that was the other obvious choice ... I'm happy for you to do that
>> if it helps you. Should be fairly trivial. My guess is that it was never
>> there because while running out of data space is trivial/common running
>> out of inodes is not.
> Okay, since you're not opposed to a separate config option, perhaps that
> makes more sense as indeed running out of inodes is by far more rare
> than the running out of disk. I'll commit the part that resurrects
> diskspacecheck=0 separately and post another patch to add diskinodecheck
> config option for a separate review.
...except that it turns out setting RPMPROB_FILTER_DISKNODES does
exactly nothing on rpm level (all rpm versions) unless
RPMPROB_FILTER_DISKSPACE is also added. SIGH.
Back to the original plan then, I'll just lump the inode check into
diskspace check and update the docs.
- Panu -
More information about the Yum-devel