[Yum-devel] [PATCH] Resurrect diskspacecheck=0 functionality

James Antill james.antill at redhat.com
Thu Apr 25 15:02:28 UTC 2013


On Thu, 2013-04-25 at 09:09 +0300, Panu Matilainen wrote:
> Something in commit fc395ef14b135b3591488816ec902057fd8d03f4 makes
> diskspacecheck=0 not disable the disk space check at all. Moving
> the thing to initActionTs() where other similar initialization
> is done makes it work again. In addition, enable filtering of
> inode problems also to behave the same as rpm's --ignorespace.

 Should change the documentation in yum.conf to explain that this does
inodes too now. Apart from that ACK.

> The related bits in _doTestTransaction() and TransactionWrapper.test()
> dont seem to do anything at least in yum context, but adding the
> inode filtering there as well just in case.

 As in, you can't see how that code is triggered? Or if you trigger the
code adding the flags does nothing?

>  OTOH unless there's
> something that actually relies on the seemingly no-op code, perhaps
> it could just be removed?

 rpmUtils/* is also an external API, so we can't just remove a function.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.baseurl.org/pipermail/yum-devel/attachments/20130425/73a27425/attachment.asc>


More information about the Yum-devel mailing list