[Yum-devel] [PATCH] Resurrect diskspacecheck=0 functionality

[Panu Matilainen]

On 04/25/2013 11:17 AM, Zdenek Pavlas wrote:
>> --- a/rpmUtils/transaction.py
>> +++ b/rpmUtils/transaction.py
>> @@ -114,7 +114,7 @@ class TransactionWrapper:
>>           # FIXME GARBAGE - remove once this is reimplemented elsehwere
>>           # KEEPING FOR API COMPLIANCE ONLY
>>           if conf.get('diskspacecheck') == 0:
>> -            self.ts.setProbFilter(rpm.RPMPROB_FILTER_DISKSPACE)
>> +            self.ts.setProbFilter(rpm.RPMPROB_FILTER_DISKSPACE|rpm.RPMPROB_FILTER_DISKNODES)
>>           tserrors = self.ts.run(cb.callback, '')
>>           self.ts.setFlags(origflags)
>
> This code is dead, as diskspacecheck is a BoolOption.
> It's True/False, but never == 0.

Yup, but python doesn't mind:

 >>> False == 0
True
 >>>

	- Panu -