[Yum-devel] [PATCH] bash completion: load yum.bash in. BZ 953210

Ville Skyttä ville.skytta at iki.fi
Wed Apr 24 19:10:54 UTC 2013


On 2013-04-22 18:20, Zdenek Pavlas wrote:
>> Cleaner IMO, upstream supported way, and one subshell + pkg-config
>> invocation less.
> 
> Yes, it's cleaner.  Can we use _xfunc in rhel7?

I don't know what's in RHEL7, but if bash-completion is, I sure hope
it's >= 2.0 (which contains _xfunc).

> Anyway, I'd rather
> just add a "_xfunc yum :" one-liner and not touch anything else.

Even though I personally wouldn't, I do think that'd be an improvement
over the previous approach.

>> if it's about >= 2.0 note that
>> the one-liner your original patch adds will require >= 2.0 (well 1.99)
>> anyway, the *.pc file didn't exist before that.
> 
> It does not, IMO.  If yum.bash is in compat dir, it has been already
> sourced, so _yum is defined so the pkg-config call is skipped.

Ah, I see.



More information about the Yum-devel mailing list