[Yum-devel] [PATCH] Add downloadonly to the userconfirm for downloads.

James Antill james at fedoraproject.org
Tue Apr 23 13:31:23 UTC 2013


On Tue, 2013-04-23 at 04:08 -0400, Zdenek Pavlas wrote:
> > +            elif uc == 'downloadonly':
> > +                self.conf.downloadonly = True
> > +                self.verbose_logger.info(_('Will exit after downloads are complete'))
> 
> It's a good idea UI-wise, and enabling --downloadonly at this point should be safe.
> ACK.
> 
> > +        aui = (dui[0], dui[1], dui[2], yui[0], yui[1], nui[0], nui[1])
> 
> That's "aui = dui + yui + nui".

 Yeh, I just extended what was there before ... but that is much easier
to read and works the same :).

> Maybe, instead of adding 2 wrappers around self.userconfirm(), we should just add
> few optional args, and call it with third=(u'd', _("download"), _("downloadonly")).

 Yeh, I thought about doing something like this at first ... but then I
wasn't sure how safe it was to extend the API of userconfirm() (anything
that inherits and has a new userconfirm() would fail when passed extra
args.).
 But I had a look at PK and yumex and neither of those have a
userconfirm(), and yum-utils just calls userconfirm() in one place. So
I'm tempted to change it.



More information about the Yum-devel mailing list