[Yum-devel] [PATCH] support socks4/5 proxies
james at fedoraproject.org
Thu Apr 18 14:43:05 UTC 2013
On Thu, 2013-04-18 at 16:01 +0200, Zdenek Pavlas wrote:
> There was a request to implement this:
Pretty sure we've had multiple BZs over the years too (might want to
search for any open ones and stick them in the commit msg).
> curl supports socks proxies via the same setopt(PROXY, url) API
> we already use for ftp/http/https proxies, so it's pretty easy.
Have you tried this?
> yum/config.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/yum/config.py b/yum/config.py
> index 438cb88..ec7ba80 100644
> --- a/yum/config.py
> +++ b/yum/config.py
> @@ -735,7 +735,8 @@ class YumConf(StartupConf):
> commands = ListOption()
> exclude = ListOption()
> failovermethod = Option(__main_failovermethod_default__)
> - proxy = UrlOption(default=False, schemes=('http', 'ftp', 'https'), allow_none=True)
> + proxy = UrlOption(default=False, schemes=('http', 'ftp', 'https',
> + 'socks4', 'socks4a', 'socks5', 'socks5h'), allow_none=True)
Seems hard to reject this, if it's really this easy to support. The
only downsides I can think of are: 1) If we ever move away from curl,
it'll be hard to support and users don't like feature regressions. 2) If
there's some weird edge case bug that's impossible to debug.
More information about the Yum-devel