[Yum-devel] [PATCH 3/4] don't queue args, only 'po's
james at fedoraproject.org
Tue Apr 9 14:50:36 UTC 2013
On Tue, 2013-04-09 at 05:48 -0400, Zdenek Pavlas wrote:
> > On Mon, 2013-04-08 at 17:08 +0200, Zdenek Pavlas wrote:
> > > ---
> > > yum/drpm.py | 22 +++++++---------------
> > > 1 file changed, 7 insertions(+), 15 deletions(-)
> > So these three change the API ... and the old API is in F19, so we
> > _need_ to rebase the F19 version before GA if you want to do these.
> > Otherwise ACK.
> IMO yum/drpm.py is a private API, used by YumBase.downloadPkgs() only.
None of the classes/functions contain any leading _'s (and some API
callers have ignored even that). Which is the only test we've ever had
for if something is public or not.
If you want to make it private then I'd "_" everything in that file,
and hope ;).
> Are there any other users?
Who knows. Probably not, but as soon as F19 goes out we'll have at
least a year where someone could and then be rightfully annoyed.
We've had enough angry people saying we "changed the API" when we
_clearly_ didn't, or changed something that was clearly marked as
private ... moving to a situation where any current and future API user
needs to guess if they can use part of the API is only going to make
everything much worse.
More information about the Yum-devel