[Yum-devel] [PATCH] resolveDeps: Keep installedFileRequires in sync. BZ 920758

James Antill james at fedoraproject.org
Tue Apr 2 22:40:19 UTC 2013


On Tue, 2013-04-02 at 03:01 -0400, Zdenek Pavlas wrote:
> >  Actually, now I think for a bit longer (ACKing at midnight ftw) I think
> > we need to set CheckRemoves=True which will call _checkFileRequires()
> > again and reset all this as a byproduct (but will also check things like
> > X requires /foo and Y provides /foo, but then we remove Y).
> 
> That won't help.  CheckRemoves is already True when we hit the problem.

 Yeh, I see that now from the BZ ... do you have a simple reproducer
too? I've spent too long trying to create a unit testcase but they keep
getting obsoleted before we get to _checkObsoletes().

 I _think_ we need to remove the "self.installedFileRequires is None"
optimization at the top of _checkFileRequires(), and probably also set
CheckRemoves (as I'm not sure it'll always be set) ... but I might just
be not seeing something obvious, and my initial ACK was correct.



More information about the Yum-devel mailing list