[Yum-devel] [PATCH 2/3] URLGrabError => RepoError, to make skip_if_unavailable work.

James Antill james at fedoraproject.org
Fri Sep 7 13:28:38 UTC 2012


On Fri, 2012-09-07 at 05:40 -0400, Zdenek Pavlas wrote:
> >  Not 100% sure we can fix this without major complaints of API
> > breakage ... also implies that skip_if_unavailable will be unhappy if
> > any URLGrabError()'s pop up ... can that happen (Eg. no more
> > mirrors?)
> 
> I'm almost sure it can't.. _getMetalink(), _getFileRepoXML()
> and _retrieveMD() clearly convert every URLGrabError to RepoError.
> 
> URLGrabError is (or it should be, IMO) used only in checkfunc
> callbacks, and never passed up in the call stack.

 Ok, if this is the only place we are leaking URLGrabError ... we can
say it's not an API break as RepoError could always be raised before
anyway.
 ACK.



More information about the Yum-devel mailing list