[Yum-devel] [PATCH 2/3] URLGrabError => RepoError, to make skip_if_unavailable work.

Zdenek Pavlas zpavlas at redhat.com
Fri Sep 7 09:40:18 UTC 2012


>  Not 100% sure we can fix this without major complaints of API
> breakage ... also implies that skip_if_unavailable will be unhappy if
> any URLGrabError()'s pop up ... can that happen (Eg. no more
> mirrors?)

I'm almost sure it can't.. _getMetalink(), _getFileRepoXML()
and _retrieveMD() clearly convert every URLGrabError to RepoError.

URLGrabError is (or it should be, IMO) used only in checkfunc
callbacks, and never passed up in the call stack.

>  Is there a problem with catching URLGrabError in the
> skip_if_unavailable code paths?

Should work, too.. but I'd prefer using RepoError.


More information about the Yum-devel mailing list