[Yum-devel] [PATCH 2/2] Nuke _check_uncompressed_db()

[James Antill]

On Fri, 2012-11-09 at 06:23 -0500, Zdenek Pavlas wrote:
> >  NAK. What is the reasoning here?
> >  As it says, this was for backwards comapt. / migration. Eg. when you
> > have primary.sqlite downloaded already the user won't be happy if you
> > decide to redownload it.
> 
> AIUI, we'd checksum .sqlite.bz2 (this didn't move, right?) and decompress
> it to "gen", unless it's already there.

 It doesn't exist anymore. The problem is that before the gen directory
we used to do roughly:

download .sqlite.bz2
decompress .sqlite.bz2 into .sqlite (removing .sqlite.bz2)

>  Is it really worth the extra code? 

 Well, if we really needed to break it for some reason it'd be a one
time hit so it's not the end of the world. But we should have a good
reason IMO, as pretty much everyone will be annoyed that one time.
 I assumed the runtime cost would be one extra stat() call or something,
is it significant or was it mainly cleanup?