[Yum-devel] [PATCH] honor retries config option at mirror group level rather than grabber level

[Mike McLean]

On Thu, Jun 28, 2012 at 12:20 PM, Mike McLean <mikem.rtp at gmail.com> wrote:
> On Thu, Jun 28, 2012 at 10:50 AM, Zdenek Pavlas <zpavlas at redhat.com> wrote:
>> You'll retry each mirror configured number of times, but only
>> for the 1st file requested.  Is that intentional?
>> Anyway, I like the 'skip-but-retry' idea.
>
> Ah, I see. My data dictionary is only getting defined once at the
> start. I see a couple options:
> 1) pass this failure_callback as a kw arg to urlgrab instead
> 2) move this logic to MirrorGroup

Updated patch and added a small patch to urlgrabber to track the
per-mirror failure counts (both total and sequential).

Note this patch also removes a mirror from the master list if it gets
$retries sequential failures. Seems like the right thing to do, but I
think it will be difficult for this to happen unless there are also
many failures across all the other mirrors.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-track-mirror-failure-counts-and-provide-data-to-call.patch
Type: application/octet-stream
Size: 1462 bytes
Desc: not available
URL: <http://lists.baseurl.org/pipermail/yum-devel/attachments/20120628/0dafe78e/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-honor-retries-config-option-at-mirror-level-rather-t.patch
Type: application/octet-stream
Size: 2262 bytes
Desc: not available
URL: <http://lists.baseurl.org/pipermail/yum-devel/attachments/20120628/0dafe78e/attachment-0001.obj>