[Yum-devel] [PATCH] Start meters immediately, and only when asked to. BZ 831904, 831291.

James Antill james at fedoraproject.org
Thu Jun 14 13:49:30 UTC 2012


On Thu, 2012-06-14 at 13:01 +0200, Zdeněk Pavlas wrote:
> URLgrabber has traditionally delayed starting of meters to first
> update, and .update() && .end() need started meters.  Instead of
> having to check this every time, start meters immediately.
> No metering of requests with progress_obj=None.

 IIRC the reason for this was that as soon as you .start() a meter it
sets download start time, and that counts towards speed. So all the time
between .start() and the first .update() which contains data is "dead
time", and you get misleadingly low N MB/s numbers that have to build up
to the correct value.
 Probably the easiest way to check if that's still true is to have
max_connections=1 and download some things from a non-local server.

 Using MultiProgress might change all this too.



More information about the Yum-devel mailing list