[Yum-devel] [PATCH 1/2] add misc.parse_pattern()

[Zdenek Pavlas]

> A bit late, but...

Fine, thanks for the feedback!

> 1) why check for the exact type, and not use isinstance?

The function was intended to work with 'str' arg only,
and the assert statement was meant to 'document' that.

> 2) why use 'str' and exclude 'unicode', as groups are translated and
> can therefore be non-ASCII? The 'you groups' command works right now with
> parameters with accents in them for instance
>         root at gibraltar:~> LC_ALL=de_DE.UTF-8 yum groups info 'Bücher

It works only because both the pattern and group names are UTF8.
(yum/comps.py converts localised names to UTF8 and then does the matching).