[Yum-devel] [PATCH 6/6] enable timedhosts

James Antill james at fedoraproject.org
Wed Feb 1 16:02:05 UTC 2012


On Wed, 2012-02-01 at 10:21 -0500, Zdenek Pavlas wrote:
> > > +        default_grabber.opts.timedhosts = self._conf.cachedir +
> > > '/timedhosts'
> > 
> >  Don't you need a hasattr() here?
> 
> We're assigning, so this should not break even with
> old urlgrabber that does not set the default value.

 Yeh, brain fart. I blame Friday :).

> > it fails in weird ways if someone has a repo. called "timedhosts" ...
> > we could just move it to <cachedir>/main/timedhosts ... or put it
> > in /var/lib/yum ... meh.
> 
> fastestmirror uses '/var/cache/yum/timedhosts.txt', so I just
> removed the extension.. 'timedhosts.yum' might be a better name.

 Yeh, I know it did. It wasn't great with the extension, but without it
it's bad.
 Don't really like the .yum ext but it's better than nothing. Blah, no
really _good_ options. Is it the same format as the fastestmirror file?
If so we could just keep using .txt ... it sucks but a little bit less
than some of the other options.



More information about the Yum-devel mailing list