[Yum-devel] RFC: yum+rpm ppc64p7 patches

Phil Knirsch pknirsch at redhat.com
Fri Apr 27 15:28:03 UTC 2012


On 04/27/2012 03:11 PM, James Antill wrote:
> On Thu, 2012-04-26 at 16:24 +0200, Phil Knirsch wrote:
>> On 04/18/2012 04:29 PM, James Antill wrote:
>>> On Wed, 2012-04-18 at 15:37 +0200, Phil Knirsch wrote:
>>>> Yea, it's kinda butt ugly, but the problem is that rpm doesn't have an
>>>> API for it, even less so for the python part that would be required.
>>>
>>>    Yeh, just seems that one of the bester cases here would be having an
>>> "rpm API" that says "give me the current AT_PLATFORM and/or AT_*".
>>>    Even if we don't move/merge "all" of the arch detection code into rpm,
>>> at least having those would be good.
>>>
>>
>> The latest patch i've attached for now basically do the same as rpm
>> does. Once we have the rpm API in place we can switch over to that
>> easily. Basically replaced the evil /bin/true ENV parsing hack with a
>> proper general purpose /proc/self/auxv parser in python directly, so
>> basically the cleanest way we can do this for now. And i've done it just
>> like in rpm, so any other arch can access and use the
>> aux_vector["platform"] and aux_vector["hwcap"] information.
>
>   Ok, did some minor cleanups and pushed (feel free to double make sure I
> didn't break anything).
>

Looks great. Main changes i saw was the prefixing of the dict and the 
parser function and the test for empty platform in the canonPPCArch() 
checker, right?

Thanks James!

Regards, Phil

-- 
Philipp Knirsch              | Tel.:  +49-711-96437-470
Supervisor Core Services     | Fax.:  +49-711-96437-111
Red Hat GmbH                 | Email: Phil Knirsch <pknirsch at redhat.com>
Hauptstaetterstr. 58         | Web:   http://www.redhat.com/
D-70178 Stuttgart, Germany


More information about the Yum-devel mailing list