[Yum-devel] [PATCH 2/4] _commonRetrieveDataMD(): split the code

Zdenek Pavlas zpavlas at redhat.com
Fri Apr 13 07:43:00 UTC 2012


>  The reason I split this is because if you are downloading N objects
>  and 1 of them has no size information, then you can't give a total size

These come from repomd.xml, and size is/was/shouldbe always set.

>  for all N objects (and thus. no "when will it finish progress" etc.)

Multi downloader handles unknown sizes fine- it's assumed to be zero
during downloading.  When finished, the total size is adjusted.

>  This will only look much worse if we async objects from multiple
>  repos. and N gets much bigger. Can we not do two passes?

Yes, we could..  but IMO it's a cosmetic issue that (if it pops out)
should be fixed in createrepo instead.


More information about the Yum-devel mailing list