[Yum-devel] [PATCH] Report IOError while setting self.conf. BZ 734907

Nils Philippsen nils at redhat.com
Mon Sep 19 13:25:32 UTC 2011


On Tue, 2011-09-06 at 10:54 -0400, Zdenek Pavlas wrote:
> >> +        except IOError, e:
> >> +            e = '%s: %s' % (to_unicode(e.args[1]), repr(e.filename))
> >> +            self.logger.critical(_('Config Error: %s'), e)
> 
> > Hmm, I'm not sure this is a "Config Error" (I read that as "you have an
> > error in your configuration files"), but rather a "System Error" or
> > whatever else we might call it when yum can't read a file (which should
> > be readable normally). Otherwise this looks good to me.
> 
> It's i18n-ed, so I just reused the closest one to save some work later,
> but I agree it's really a bit off.  Maybe drop the prefix altogether, as
> 
> - CRITICAL:yum.cli:Config Error: Permission denied: '///var/lib/yum/uuid'
> + CRITICAL:yum.cli:Permission denied: '///var/lib/yum/uuid'
> 
> is clear enough?

Yes. Perhaps filter e.filename through os.path.normpath to eliminate the
triple slashes? From where do they even come?

Nils
-- 
Nils Philippsen      "Those who would give up Essential Liberty to purchase 
Red Hat               a little Temporary Safety, deserve neither Liberty
nils at redhat.com       nor Safety."  --  Benjamin Franklin, 1759
PGP fingerprint:      C4A8 9474 5C4C ADE3 2B8F  656D 47D8 9B65 6951 3011



More information about the Yum-devel mailing list