[Yum-devel] [PATCH 2/2] getMetalink, getFile: Use grabfunc.
zpavlas at redhat.com
Thu Sep 15 15:21:24 UTC 2011
> I think the idea behind both of these patches are ok, but I'm not 100%
> sure ... how much/what testing have you done?
Checked that 'yum clean all' + 'yum update' runs fine.
(downloads metalinks, repomds, and primary metadata).
This does not cover the _getFile() with url != None case,
in fact I have never seen that being used..
> This last bit is wrong though, as a bunch of the things passed to
> URLGrabber are local variables:
Yes, I've later noticed that as well.. kwargs should be moved
to self.grabfunc.urlgrab() call, not just removed. Fixed that.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 2916 bytes
Desc: not available
More information about the Yum-devel