[Yum-devel] [PATCH] yum-debug-restore: restore installonly pkgs. BZ 737597.

Zdenek Pavlas zpavlas at redhat.com
Wed Nov 9 07:44:39 UTC 2011


Argh, two typos in a 9-line patch.

> without having to change anything from "if" to
> "elif" ... and so all the conditionals line up.

Aye.

> 
> > +            if not po.pkgtup in opkgtups:
> > +                ret.append(("remove", pkgtup2str(*po.pkgtup)))
> 
>  The * is wrong here ... we also generally don't do it for
>  non-function arguments as RHEL-5 python is too old to accept that.

That's a typo, it was naevr2str() originally.

> >      for name, arch in sorted(opkgmaps):
> > +        if name in installonly:
> > +            continue
> 
>  Doesn't this mean it doesn't install any installonly packages?

This iterates over opkgmaps, installing only one EVR for each NA.
I could try to skip these in opkgtups loop, but this is much simpler.

> > +    for pkgtup in opkgtups:
> > +        if pkgtup[0] in installonly and not pkgtup in npkgtups:
> > +            ret.append(("remove", pkgtup2str(pkgtup)))
                              ^^^^^^

A copy-paste bug.  Should have been install.


More information about the Yum-devel mailing list