[Yum-devel] [PATCH] Make yum-cron code and config files prettier.

James Antill james at fedoraproject.org
Thu Jul 28 22:17:25 UTC 2011


On Thu, 2011-07-28 at 17:59 -0400, Matthew Miller wrote:
> On Thu, Jul 28, 2011 at 05:51:23PM -0400, James Antill wrote:
> >  Are you actually using any of the magic/fancy features of [[ vs. [ ?
> >  If not, it seems better to just use [ and not confuse everyone
> > (including me :).
> 
> In a couple of places, yes. And then I figured it was better to make them
> all be that way to be consistent

 Uh ... fair enough, I'm not sure which is better though consistency or
knowing which if statements to give the big hairy eyeball to.

> >  Also, if you can, could you do this as multiple patches ... one which
> > does the _really_ obvious changes (like changing comments), and one
> > which does the LOCKFILE => PIDFILE change etc?
> 
> Yes, although that'll be tomorrow, since I did it by going straight through
> each file rather than sensibly breaking each change into a separate, sane
> commit. I'll try to be more restrained in the future. :)
> 
> I can also split the config file comments from the code comments; the former
> is really end-user documentation while the latter is just prettification.

 splitting the file into different patches is nice, and I do appreciate
it ... but the main thing is if you can split the "doesn't do anything"
patches from the ones that do. That way I can skim 100+ lines of comment
changes, and not have to think about them.



More information about the Yum-devel mailing list