[Yum-devel] [PATCH] Make yum-cron code and config files prettier.

James Antill james at fedoraproject.org
Thu Jul 28 21:51:23 UTC 2011


On Thu, 2011-07-28 at 17:40 -0400, Matthew Miller wrote:
> On Thu, Jul 28, 2011 at 05:20:35PM -0400, James Antill wrote:
> >  *nods*, pushed these ... more patches please :).
> 
> Cool. Here's one more, which _should_ only be cosmetic and have no changes
> in functionality. The caveat is that I've only tested it lightly -- like, in
> the past fifteen minutes. So it may have some accidentally-introduced bugs,
> which in any case I promise to smooth out quickly. (It's now running live on
> a couple of test systems, so I should find out.) If you want to wait to push
> this one I understand. :)

 Are you actually using any of the magic/fancy features of [[ vs. [ ?
 If not, it seems better to just use [ and not confuse everyone
(including me :).

 Also, if you can, could you do this as multiple patches ... one which
does the _really_ obvious changes (like changing comments), and one
which does the LOCKFILE => PIDFILE change etc?



More information about the Yum-devel mailing list