[Yum-devel] [yum-utils] package-graph

James Antill james at fedoraproject.org
Fri Jan 21 21:21:09 UTC 2011


On Fri, 2011-01-21 at 17:33 +0100, Pierre-Yves wrote:
> On Fri, 2011-01-21 at 09:36 -0500, James Antill wrote:
> > 
> > ...so we don't have the indentation change?
> 
> I tried to fix this.

 Looks good.

> > 2. There are three places where this happens:
> > 
> > +        if dot is None:
> > +            self._tree_print_req(pkg, req, level)
> > +            lim = level
> > +        else:
> > +            dot.addPackage(pkg, rpkgs)
> > +            lim = level + 1
> > 
> > ...why is "lim" a different number depending on if it's ascii or dot?
> 
> Because the function addPackage links one package to all it
> dependencies, so it does the iteration over the packages itself.
> I could rewrite it so that it links one package to one of his dependency
> (in a similar way than we do for the ascii-tree) but then we loose the
> coloring.

 The problem I worry about is that doesn't that make:

repoquery --level=2 --requires --output=ascii-tree
repoquery --level=2 --requires --output=dot-tree

...behave differently?



More information about the Yum-devel mailing list