[Yum-devel] problem with rpmUtils.transaction.py patch

[seth vidal]

On Fri, 2011-02-18 at 10:02 +0200, Panu Matilainen wrote:
> On 02/18/2011 12:42 AM, seth vidal wrote:
> > in rpmUtils.transaction.py
> >
> > this patch
> > http://tinyurl.com/6ds7ekw
> >
> > imports to_str from yum.i18n
> >
> > this blows up anyone attempting to import rpmUtils.miscutils recursive
> > import.
> >
> > the trace is here
> >
> > http://fpaste.org/Oj0f/
> >
> > the problem is that 'yum' imports things - specifically config which
> > ends up grabbing in rpmUtils.miscutils.
> 
> Ugh, my bad. Sorry about that.
> 
> > so we need to either:
> > 1. move to kitchen
> > 2. stop using to_str() there
> > 3. move all of YumBase() into it's own file so __init__.py is just a
> > blank stub and then deal with all the pain of the massive API break.
> >
> > but in general we shouldn't be importing from yum out of rpmUtils, I
> > think.
> >
> > I'm going to hack something in for rawhide (probably just (str) in the
> > ts.check() call - to make it work.
> >
> > anyone have a preference on 1-3 above?
> 
> I'd actually vote for
> 
> 4. just move the thing back to yum-side where it originally was, an 
> internal helper function of YumBase
> 
> There's no Great Big Benefit to having the ts wrapper check do what it 
> now does, certainly not worth 1 or 3. And come to think of it, commit 
> c54c9082d702b6ba45620ecf3ca5834b9b104543 is actually an API change too, 
> even if its unlikely that anybody would notice.
> 

+1
-sv