[Yum-devel] [PATCH 1/2] Move rpm version comparison flags from depsolve to rpmsack

Panu Matilainen pmatilai at laiskiainen.org
Wed Feb 16 07:26:57 UTC 2011


On 02/15/2011 05:07 PM, James Antill wrote:
> On Tue, 2011-02-15 at 13:06 +0200, Panu Matilainen wrote:
>> Avoids unnecessary import dependency from rpmsack to the higher
>> level depsolve class, allowing rpmsack to be used earlier.
>> ---
>>   yum/depsolve.py |    7 +------
>>   yum/rpmsack.py  |   11 ++++++++---
>>   2 files changed, 9 insertions(+), 9 deletions(-)
>
>   ACK, I guess. Although this is just for the config. usage?
>   It esp. feels kind of weird as there are a couple of other uses of
> rpm.blah in depsolve still.
>   ts_flags_to_rpm seems like it'd be easy to move to rpmsack, the bit in
> processConflict is much more blah though.

BTW, I just realized there's a more appropriate place for these all 
(assuming they're to be moved at all) - yum.constants, which describes 
itself as:
"Yum constants. Usually dealing with rpm magic numbers."

	- Panu -


More information about the Yum-devel mailing list