[Yum-devel] [PATCH] Use rpmsack returnGPGPubkeyPackages() in YumBase.gpgKeyCheck()

James Antill james at fedoraproject.org
Tue Feb 15 14:56:33 UTC 2011


On Tue, 2011-02-15 at 11:54 +0200, Panu Matilainen wrote:
> Reduces code duplication and unnecessary rpmdb reopens. The rpmdb
> gets opened shortly afterwards anyway and closed before any downloads
> so there should be no unwanted side-effects.
> ---
>  yum/__init__.py |    9 +--------
>  1 files changed, 1 insertions(+), 8 deletions(-)

 NAK. As soon as you call rpmdb.returnGPGPubkeyPackages() then
rpmdb.returnPackages() needs to filter those "packages" out on each
call.



More information about the Yum-devel mailing list