[Yum-devel] [PATCH 2/2] Make ts.check() unconditional + adjust related messages

Panu Matilainen pmatilai at laiskiainen.org
Wed Feb 9 14:44:20 UTC 2011


On 02/09/2011 04:40 PM, James Antill wrote:
> On Wed, 2011-02-09 at 15:59 +0200, Panu Matilainen wrote:
>> ts.check() is not really an optional call, as there are dependencies
>> which yum does not check for (notably rpmlib() dependencies). Always
>> call ts.check(), looking at the return values.
> [...]
>
>> --- a/yum/config.py
>> +++ b/yum/config.py
>> @@ -691,7 +691,6 @@ class YumConf(StartupConf):
>>       metadata_expire = SecondsOption(60 * 60 * 6) # Time in seconds (6h).
>>       # Time in seconds (1 day). NOTE: This isn't used when using metalinks
>>       mirrorlist_expire = SecondsOption(60 * 60 * 24)
>> -    rpm_check_debug = BoolOption(True)
>>       disable_excludes = ListOption()
>>       skip_broken = BoolOption(False)
>>       #  Note that "instant" is the old behaviour, but group:primary is very
>
>   Pretty sure we can't remove this, due to API compat. Otherwise, ACK.

So instead of removing it, add a comment it's unused?

	- Panu -


More information about the Yum-devel mailing list