[Yum-devel] [PATCH 1/2] add misc.parse_pattern()
Zdeněk Pavlas
zpavlas at redhat.com
Mon Dec 19 16:13:15 UTC 2011
---
yum/comps.py | 5 ++---
yum/misc.py | 6 ++++++
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/yum/comps.py b/yum/comps.py
index 65f6d5e..7955838 100755
--- a/yum/comps.py
+++ b/yum/comps.py
@@ -23,7 +23,7 @@ from Errors import CompsException
import fnmatch
import re
from yum.i18n import to_unicode
-from misc import get_my_lang_code
+from misc import get_my_lang_code, parse_pattern
from yum.misc import cElementTree_iterparse as iterparse
lang_attr = '{http://www.w3.org/XML/1998/namespace}lang'
@@ -416,8 +416,7 @@ class Comps(object):
"""return all groups which match either by glob or exact match"""
returns = {}
- for item in group_pattern.split(','):
- item = item.strip()
+ for item in parse_pattern(group_pattern):
if item in self._groups:
thisgroup = self._groups[item]
returns[thisgroup.groupid] = thisgroup
diff --git a/yum/misc.py b/yum/misc.py
index 8644978..5f874f7 100644
--- a/yum/misc.py
+++ b/yum/misc.py
@@ -1196,3 +1196,9 @@ def cElementTree_xmlparse(filename):
""" Lazily load/run: cElementTree.parse """
_cElementTree_import()
return __cached_cElementTree.parse(filename)
+
+def parse_pattern(pattern):
+ """ Split a string to a list of package or group patterns.
+ """
+ assert type(pattern) == str
+ return [s.strip() for s in pattern.split(',')]
--
1.7.4.4
More information about the Yum-devel
mailing list