[Yum-devel] [PATCH] Do not hide error messages when opening metadata

Zdeněk Pavlas zpavlas at redhat.com
Wed Dec 14 16:04:04 UTC 2011


'Cannot retrieve repository metadata (repomd.xml) for repository XY'
does not help much, IMO.  The original exception (download failed,
file does not exist, etc) is more descriptive.  We should:

a) include it in the wrapping message
b) do not wrap it at all

This patch implements b)

I'm aware that there was probably a reason to add this to yum
and removing it could break something..
---
 yum/yumRepo.py |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/yum/yumRepo.py b/yum/yumRepo.py
index 00622ce..e854192 100644
--- a/yum/yumRepo.py
+++ b/yum/yumRepo.py
@@ -1502,12 +1502,7 @@ Insufficient space in download directory %s
     def _getRepoXML(self):
         if self._repoXML:
             return self._repoXML
-        try:
-            self._loadRepoXML(text=self)
-        except Errors.RepoError, e:
-            msg = ("Cannot retrieve repository metadata (repomd.xml) for repository: %s. "
-                  "Please verify its path and try again" % self )
-            raise Errors.RepoError, msg
+        self._loadRepoXML(text=self)
         return self._repoXML
 
 
-- 
1.7.4.4



More information about the Yum-devel mailing list