[Yum-devel] [PATCH 1/3] Clean up class MultiFileHelper

Zdenek Pavlas zpavlas at redhat.com
Fri Aug 26 07:56:39 UTC 2011


>>      def _do_end(self, amount_read, now):
>> -        self.ftotal_time = format_time(now - self.start_time)
>> -        self.ftotal_size = format_number(self.last_amount_read)
>>          self.master.end_meter(self, now)

> urlgrabber has a published API.. This is part of it.
> We can't break it.

How one finds out what makes up the published API?
Search for ftotal_time, ftotal_size, and urlgrabber
gives nothing but the source.

MultiFileHelper is an abstract proxy to forward calls
to the master meter, so formatting shouldn't be there,
and I have found no single user of these attributes.

Zdenek


More information about the Yum-devel mailing list