[Yum-devel] [PATCH 1/3] Clean up class MultiFileHelper

seth vidal skvidal at fedoraproject.org
Thu Aug 25 14:08:04 UTC 2011


On Thu, 2011-08-25 at 11:55 +0200, Zdeněk Pavlas wrote:
> These lines look irrelevant and confusing.
> 
> ---
>  urlgrabber/progress.py |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/urlgrabber/progress.py b/urlgrabber/progress.py
> index 45eb248..e8408e5 100644
> --- a/urlgrabber/progress.py
> +++ b/urlgrabber/progress.py
> @@ -317,12 +317,9 @@ class MultiFileHelper(BaseMeter):
>          self.master.start_meter(self, now)
>  
>      def _do_update(self, amount_read, now):
> -        # elapsed time since last update
>          self.master.update_meter(self, now)
>  
>      def _do_end(self, amount_read, now):
> -        self.ftotal_time = format_time(now - self.start_time)
> -        self.ftotal_size = format_number(self.last_amount_read)
>          self.master.end_meter(self, now)
>  
>      def failure(self, message, now=None):


urlgrabber has a published API.. This is part of it.

We can't break it.

-sv




More information about the Yum-devel mailing list