[Yum-devel] [PATCH 3/3] fix the unittests to remove the FIXMEs b/c now they are fixed.

Seth Vidal skvidal at fedoraproject.org
Tue Oct 19 20:49:03 UTC 2010


---
 test/simpleobsoletestests.py |   10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/test/simpleobsoletestests.py b/test/simpleobsoletestests.py
index dfaa7e5..97a9923 100644
--- a/test/simpleobsoletestests.py
+++ b/test/simpleobsoletestests.py
@@ -560,10 +560,7 @@ class SimpleObsoletesTests(OperationsTests):
         res, msg = self.runOperation(['install', 'dapl-2.0.15'], rps, aps)
 
         self.assert_(res=='ok', msg)
-        # This will almost certainly fail, but it's pretty weird:
-        self.assertResult((all['arp3'], all['aoop1'], all['aoop2']))
-        # FIXME: Optimally we'd get:
-        # self.assertResult((all['arp3'], all['arp4']))
+        self.assertResult((all['arp3'], all['arp4']))
     def testRLDaplMessWeirdUp1(self):
         rps, aps, ret, all = self._helperRLDaplMess()
         res, msg = self.runOperation(['update', 'dapl-1.2.1.1-7'], rps, aps)
@@ -582,10 +579,7 @@ class SimpleObsoletesTests(OperationsTests):
         res, msg = self.runOperation(['update', 'dapl-2.0.15'], rps, aps)
 
         self.assert_(res=='ok', msg)
-        # This will almost certainly fail, but it's pretty weird:
-        self.assertResult((all['arp3'], all['aoop1'], all['aoop2']))
-        # FIXME: Optimally we'd get:
-        # self.assertResult((all['arp3'], all['arp4']))
+        self.assertResult((all['arp3'], all['arp4']))
 
     def testRLDaplFixUpdateNotInstall(self):
         rps, aps, ret, all = self._helperRLDaplMess()
-- 
1.7.2.1



More information about the Yum-devel mailing list