[Yum-devel] [PATCH] Fix syslog_indent and syslog_facility settings, improve syslog format.

[Ville Skyttä]

On Wednesday 24 March 2010, James Antill wrote:
> On Wed, 2010-03-24 at 18:33 +0200, Ville Skyttä wrote:
> > ---
> > 
> >  yum/logginglevels.py |   59
> >  ++++++++++++++++++++++--------------------------- 1 files changed, 27
> >  insertions(+), 32 deletions(-)
> > 
> > diff --git a/yum/logginglevels.py b/yum/logginglevels.py
> > index 3d82b55..1de8ef0 100644
> > --- a/yum/logginglevels.py
> > +++ b/yum/logginglevels.py
[...]
> 
>  Could you change all this to just do:
> > -import syslog as syslog_module
> > +syslog_module = logging.handlers.SysLogHandler
> 
> ...it's a little evil, but it'll save 50% on the patch.

Ok, will do.

[...]
> 
>  ACK.
>  Although the commit should probably say that we are now allowing remote
> syslog "devices".

Hm, but this particular patch quoted in your reply doesn't do that, it's the 
other one with the subject "[PATCH 2/2] Allow host:port values for 
syslog_device.".  Can I count this as an ACK for that one (with the commit 
message tweaked)? ;)