[Yum-devel] [PATCH] make sure we aren't overwriting the value of 'keys'

Seth Vidal skvidal at fedoraproject.org
Tue Mar 23 14:10:23 UTC 2010


this determines how many args we pass back in our yielded results
never noticed it b/c nothing in yum uses keys=True - but it broke PK
---
 yum/__init__.py |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/yum/__init__.py b/yum/__init__.py
index ea73549..0aaa819 100644
--- a/yum/__init__.py
+++ b/yum/__init__.py
@@ -2163,10 +2163,10 @@ class YumBase(depsolve.Depsolve):
 
         # do the ones we already have
         for item in sorted_lists.values():
-            for pkg, keys, values in item:
+            for pkg, k, v in item:
                 if pkg not in results_by_pkg:
                     results_by_pkg[pkg] = []
-                results_by_pkg[pkg].append((keys,values))
+                results_by_pkg[pkg].append((k,v))
 
         # take our existing dict-by-pkg and make the dict-by-count for 
         # this bizarro sorted_lists format
@@ -2175,9 +2175,9 @@ class YumBase(depsolve.Depsolve):
         for pkg in results_by_pkg:
             totkeys = []
             totvals = []
-            for (keys, values) in results_by_pkg[pkg]:
-                totkeys.extend(keys)
-                totvals.extend(values)
+            for (k, v) in results_by_pkg[pkg]:
+                totkeys.extend(k)
+                totvals.extend(v)
             
             totkeys = misc.unique(totkeys)
             totvals = misc.unique(totvals)
-- 
1.6.6



More information about the Yum-devel mailing list