[Yum-devel] [PATCH] Fix 0 vs None Epoch handling in compareEVR().

seth vidal skvidal at fedoraproject.org
Mon Jun 14 16:58:17 UTC 2010

On Mon, 2010-06-14 at 19:54 +0300, Panu Matilainen wrote:
> IMO if something relies on the current compareEVR() behavior wrt 0 vs None 
> epoch then it's about time we fix that something instead. The issue is 
> getting a bit long in the tooth, 8 years and still it keeps popping up 
> every now and then.
> Oh and FWIW, that you actually need a convenience wrapper around
> labelCompare() is just plain silly. labelCompare() should perform the 
> legitimate conversions as needed by itself. Will fix, but of course before 
> that's available widely enough for yum to use... oh well.

you know why there's a convenience wrapper around labelCompare()?

b/c at one point in time if by any bad chance you passed in a None to
epoch or version labelCompare() would SEGFAULT.

And at that time getting someone to fix things in rpm was....
complicated, as I'm sure you know.


More information about the Yum-devel mailing list