[Yum-devel] [PATCH] Fix 0 vs None Epoch handling in compareEVR().

seth vidal skvidal at fedoraproject.org
Mon Jun 14 16:33:16 UTC 2010


On Mon, 2010-06-14 at 19:26 +0300, Panu Matilainen wrote:

> Well, current compareEVR() behavior in the first case is just plain wrong. 
> Maybe this doesn't come up in yum/repomd context, but if somebody uses 
> compareEVR() as a convenience wrapper (which it basically is) over 
> labelCompare() when working with actual headers it can bite you.

That's great - it's still odd we've not ever seen a bug report on it
afaict.

which is my point. I don't like it when I hear the words:
"obviously wrong" and "plain wrong" and no one can find a bug that
anyone has seen to PROVE this point.

It gets my hackles up that we're fixing things that might be in a "I've
been relying on that bug" place.


but I read the example cases and I said "sure let's give the patch a
shot and see what happens".

hopefully nothing happens, but I'm not that optimistic of a person.

-sv




More information about the Yum-devel mailing list