[Yum-devel] [PATCH] make sure we add our '\n's in the right place to keep the xml output 'pretty'

Seth Vidal skvidal at fedoraproject.org
Fri Jun 4 15:02:24 UTC 2010


closes rh bug:  https://bugzilla.redhat.com/show_bug.cgi?id=600201
---
 yum/packages.py |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/yum/packages.py b/yum/packages.py
index 4687cd3..aedabe6 100644
--- a/yum/packages.py
+++ b/yum/packages.py
@@ -1039,7 +1039,10 @@ class YumAvailablePackage(PackageObject, RpmBase):
         msg += self._dump_pco('conflicts')         
         msg += self._dump_pco('obsoletes')         
         msg += self._dump_files(True)
-        msg += """\n  </format>"""
+        if msg[-1] != '\n':
+            msg += """\n"""
+        msg += """  </format>"""
+        
         return msg
 
     def _dump_pco(self, pcotype):
@@ -1065,7 +1068,7 @@ class YumAvailablePackage(PackageObject, RpmBase):
         return msg
     
     def _dump_files(self, primary=False):
-        msg =""
+        msg ="\n"
         if not primary:
             files = self.returnFileEntries('file')
             dirs = self.returnFileEntries('dir')
-- 
1.7.0.1



More information about the Yum-devel mailing list