[Yum-devel] [PATCH] stop format_missing_requires from exploding, if ayum is not set

[James Antill]

On Tue, 2010-01-26 at 14:36 +0100, Tim Lauridsen wrote:
> -            if yb.tsInfo.getMembersWithState(pkg.pkgtup,
> TS_INSTALL_STATES):
> -                action = _('Installing')
> -            msg += _('\n    %s: %s (%s)') % (action, pkg, pkg.repoid)
> +        if yb: # yb could be None, if ayum not is passed as value to
> __init__ 
> +            ipkgs = set()
> +            for pkg in sorted(yb.rpmdb.getProvides(needname)): 

 This is just an indentation change, yeh? With the above test?

 Can you do:

 if not yb:
     return msg

...and turn it into a 2 line patch? Auto ack for that. Also maybe add a
comment about how ayum can be None here.