[Yum-devel] [PATCH] Improve number formatting in CLI output.
Ville Skyttä
ville.skytta at iki.fi
Mon Jan 18 16:39:00 UTC 2010
On Wednesday 06 January 2010, Ville Skyttä wrote:
>
> I didn't think anything's necessarily "broken" when I wrote the patch, and
> converting to floats doesn't sound like what I'd personally want.
>
> If the size of something is really exactly zero, I'd personally want it to
> be displayed as 0 instead of 0.0 (suffix symbols aside). That's what the
> other part of the patch implements. Could be that I'd want that for some
> other cases too (perhaps everything below 1000 or so (== ones that don't
> have a suffix symbol) if it fits without converting to decimal) but I
> don't have test cases for those at hand, just fixed the one case that I
> ran into and was mildly annoyed about.
>
> But now I see adding the "k" would be wrong in some cases, so the attached
> revised patch changes it to " ".
Could I get an ACK/NACK for this patch, or parts of it? I suppose at least
the change from '' to ' ' to fix the alignment issue would be non-
controversial...
More information about the Yum-devel
mailing list