[Yum-devel] Something is broken :(

[Tim Lauridsen]

On Fri, Jan 15, 2010 at 1:43 PM, Tim Lauridsen <tim.lauridsen at googlemail.com
> wrote:

> $ make test-skipbroken
>
> ...
> ...
>
> *----------------------------------------------------------------------
> Ran 27 tests in 0.446s
>
> FAILED (errors=24)
> make: *** [test-skipbroken] Error 1
>
>
> and lots of
>
> Traceback (most recent call last):
>   File "/home/tilau/udv/work/yum/test/skipbroken-tests.py", line 101, in
> testUpdateRequireOld
>     self.assertEquals('empty', *self.resolveCode(skip=True))
>   File "/home/tilau/udv/work/yum/test/skipbroken-tests.py", line 624, in
> resolveCode
>     res, msg = solver.buildTransaction()
>   File "./yum/__init__.py", line 815, in buildTransaction
>     (rescode, restring) = self.resolveDeps()
>   File "./yum/depsolve.py", line 714, in resolveDeps
>     CheckDeps, checkinstalls, checkremoves, missing =
> self._resolveRequires(errors)
>   File "./yum/depsolve.py", line 816, in _resolveRequires
>     (checkdep, missing, errormsgs) = self._processReq(po, dep)
>   File "./yum/depsolve.py", line 283, in _processReq
>     CheckDeps, missingdep = self._requiringFromTransaction(po, requirement,
> errormsgs)
>   File "./yum/depsolve.py", line 525, in _requiringFromTransaction
>     msg = self._err_missing_requires(requiringPo, requirement)
>   File "./yum/depsolve.py", line 317, in _err_missing_requires
>     ui_req = rpmUtils.miscutils.formatRequire(needname, needversion,
> NameError: global name 'needname' is not defined
>
> Tim
> *


It was a refactoring error

I fixed it here

http://yum.baseurl.org/gitweb?p=yum.git;a=commitdiff;h=9bb6377291a8446feefa8252dff28fb616ebfe34

I was a reel nobrainer, so i skipped the mail list review, hope it is ok

Tim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.baseurl.org/pipermail/yum-devel/attachments/20100115/547090e1/attachment.htm>