[Yum-devel] [PATCH 1/2] if we define multiple command names in getNames() make sure we display them all in the usage
seth vidal
skvidal at fedoraproject.org
Thu Aug 19 05:27:31 UTC 2010
On Thu, 2010-08-19 at 01:16 -0400, James Antill wrote:
> On Wed, 2010-08-18 at 22:21 -0400, Seth Vidal wrote:
> > even if we do get some duplicate summaries
> > ---
> > cli.py | 15 ++++++++-------
> > 1 files changed, 8 insertions(+), 7 deletions(-)
>
> I don't like this, if you really want N commands the std. way is to do
> what ListCommand/etc. do. And I used this method in the security plugin
> so there wouldn't be 7 commands just for the back compat. stuff.
> Saying that if you really want to, I don't mind as long as there is a
> new blessed way to "hide" the compat. commands.
>
The problem is that there is no way to discover those other commands in
the security plugin w/o knowing about them. And anyone who copies from
the security plugin for their own will stumble down that path.
I ran into it b/c that's where I started for the appmarket plugin I was
messing with. When I noticed that the commands were not all being listed
I found that the uniqueing of the commands in makeUsage as the problem.
so my deal is this: If we're not going to change it then at least mark
up the security plugin to explain it.
-sv
More information about the Yum-devel
mailing list