[Yum-devel] [PATCH 1/2] add globdir: syntax to all ListOption() and UrlListOption() items in config.py

Seth Vidal skvidal at fedoraproject.org
Mon Apr 26 20:38:30 UTC 2010



On Mon, 26 Apr 2010, Seth Vidal wrote:

>
>
> On Mon, 26 Apr 2010, Ville Skyttä wrote:
>
>> Maybe a dumb question, but why is the globdir: prefix needed?  Isn't it 
>> enough
>> that if a path contains one or more globbing characters, it will be treated 
>> as
>> a glob pretty much as described above?
>
> b/c it is perfectly reasonable for list items (like excludes) to include glob 
> chars and NOT be a dir.
>
>
>> If not, I'd suggest renaming it into simply glob: because I believe the 
>> intent
>> is that /path/somewhere.d/*.conf will match _files_ matching that glob, and
>> it's not completely clear what the "dir" is (somewhere.d or *.conf or ...?)
>
> I'm fine with it being a different name - sure.
>
> but I do think we need a prefix.

changed it to glob: and pushed

-sv


More information about the Yum-devel mailing list