[Yum-devel] [PATCH] Make mdpolicy to be a list, to give users/callers greater control
tim.lauridsen at googlemail.com
Thu Oct 8 07:34:22 UTC 2009
On 10/07/2009 03:51 PM, Seth Vidal wrote:
> On Wed, 7 Oct 2009, Tim Lauridsen wrote:
>> On 10/06/2009 11:16 PM, James Antill wrote:
>> Looks good to me
> It's fine that this change went in but I'd like to note a couple of
> things here for posterity:
> 1. this is technically an api-break. If anyone was using this in an odd
> way their code would break.
> 2. Since, afaict, no one uses this at all, maybe we should consider
> marking this as something to deprecate when we do decide to break the api.
At first look, the code had some compatibility for handling
conf.mdpolicy as a string.
But if some api user does very weird stuff with conf.mdpolicy then something might break
and a yum.conf containing
mdpolicy = value1,value2
might break on a yum not containing the new code.
But then it very theoretical and I don't think anyone has used it yet, but is a api-break.
and the most correct way to handle it is to add a new option and deprecate the old one.
but in the current case, i think we can live with the break.
More information about the Yum-devel