[Yum-devel] [PATCH] Match only current language instead of all in group/category searches.

Seth Vidal skvidal at fedoraproject.org
Mon Nov 2 14:38:51 UTC 2009



On Mon, 2 Nov 2009, James Antill wrote:

> On Sat, 2009-10-31 at 22:00 +0200, Ville Skyttä wrote:
>> On Saturday 31 October 2009, Seth Vidal wrote:
>>> nack - I'm pretty certain we're matching all langs intentionally.
>>
>> I'd be interested in hearing the rationale.
>>
>> The consequence I observe is that globbing operations currently produce
>> results a lot of which look plain bogus because only the localized name is
>> printed.  Your globs hit things that you didn't know even existed, and the
>> reason is in no way decipherable from the results displayed to you.  Matching
>> only the current language would not eliminate the problem as long as things
>> are matched against the untranslated name and id of the group/category (which
>> is understandable), but IMO it would significantly improve it.
>>
>> Just try something, for example 'yum grouplist "h*"' gets me a list of 59
>> groups, of which 6 start with a 'h' which is what I asked.  After applying
>> this patch, I get only those 6 (incidentally - for other queries it'll still
>> produce some "odd" matches but less than before).
>
> We could maybe split this up for different operations, or maybe match
> all translated names but only for direct (non-wildcard) matches.
> I think the problem we wanted to avoid is people having stuff like:
>
> yum groupinstall 'Servidor de nombres DNS'
>
> ...in some script which is in the C locale (or even kickstart).
>

something like that. also the:

"I run my user in my lang but system is C".

-sv


More information about the Yum-devel mailing list