[Yum-devel] [PATCH] correct searchFiles for primary file search

Seth Vidal skvidal at fedoraproject.org
Wed Aug 26 16:16:47 UTC 2009



On Wed, 26 Aug 2009, James Antill wrote:

> On Wed, 2009-08-26 at 07:38 -0400, Seth Vidal wrote:
>> when we performing searchFiles() against the sqlitesacks we were not checking
>> if the file names were from the set of files that the primarydb has already.
>> So we were downloading the filelistsdb in a bunch of cases where we simply
>> didn't need to. This fixes the simple case of: there are no globs and the
>> file is a primary. It also marks a fixme to be finished that there are
>> globs but the globs matches up to a primarydb file. I'll get to that one shortly.
>> ---
>>  yum/sqlitesack.py |   24 ++++++++++++++++++++++++
>>  1 files changed, 24 insertions(+), 0 deletions(-)
>
> ACK.
> Although I assume this means the bottom of _search() can/should die, as
> should the bit in searchPrco() ... so can you do that too?

alternatively- just swap it around.


make searchFiles() call _search() directly for the provides - which is 
what I've just done - I'll post a new patch shortly.

-sv





More information about the Yum-devel mailing list